lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Rutherglen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3493) Solr reopen on a custom reader doesn't work
Date Thu, 06 Oct 2011 16:09:29 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122033#comment-13122033
] 

Jason Rutherglen commented on LUCENE-3493:
------------------------------------------

Uwe, I'd like to agree with you, however I cannot (because then I wouldn't have had to create
an issue!).  Look at DR.doOpen* methods.  They're private.  There's no reason for them to
be.  They need to be protected, that's in the next patch.  Fairly simple.  The follow on to
this is overriding IW to return custom readers.  I had an issue and patch for that a while
back.  It's best to implement both here, as Lucene 4.x Solr's NRT will show the same problem!

I think you're right, looks like this *could* be done be overriding doOpenIfChanged* however,
it doesn't make sense to duplicate code!
                
> Solr reopen on a custom reader doesn't work
> -------------------------------------------
>
>                 Key: LUCENE-3493
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3493
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 3.4
>            Reporter: Jason Rutherglen
>            Priority: Blocker
>         Attachments: LUCENE-3493.patch
>
>
> When a custom index reader is used with Solr and reopen, the custom reader vanishes after
the reopen.  It's a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message