lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2861) transaction log / realtime-get failures
Date Sun, 30 Oct 2011 23:07:32 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139823#comment-13139823
] 

Simon Willnauer commented on SOLR-2861:
---------------------------------------

tricky shit man! I think I found the issue! we only check the bufferedDeleteStream for changes
in IW#nrtIsCurrent instead we should check the deleteQueue since there could be some deletes
still in the queue but not yet applied to the delete stream. here is a diff though:

{code}
Index: java/org/apache/lucene/index/IndexWriter.java
===================================================================
--- java/org/apache/lucene/index/IndexWriter.java	(revision 1195214)
+++ java/org/apache/lucene/index/IndexWriter.java	(working copy)
@@ -4074,7 +4074,7 @@
   synchronized boolean nrtIsCurrent(SegmentInfos infos) {
     //System.out.println("IW.nrtIsCurrent " + (infos.version == segmentInfos.version &&
!docWriter.anyChanges() && !bufferedDeletesStream.any()));
     ensureOpen();
-    return infos.version == segmentInfos.version && !docWriter.anyChanges() &&
!bufferedDeletesStream.any();
+    return infos.version == segmentInfos.version && !docWriter.anyChanges() &&
!docWriter.deleteQueue.anyChanges();
   }
{code}

yonik, I didn't try this since I only looked at the code for a little while to figure out
what could be the reason you see this. Can you verify?

                
> transaction log / realtime-get failures 
> ----------------------------------------
>
>                 Key: SOLR-2861
>                 URL: https://issues.apache.org/jira/browse/SOLR-2861
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: TEST-org.apache.solr.search.TestRealTimeGet.xml, fail4.xml, fail5.xml,
jenkins_output.txt, solr_debug.patch, trunk-0.txt
>
>
> realtime-get or the transaction log fails sometimes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message