lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Fanxi (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (SOLR-792) Pivot (ie: Decision Tree) Faceting Component
Date Wed, 19 Oct 2011 09:58:10 GMT

    [ https://issues.apache.org/jira/browse/SOLR-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130461#comment-13130461
] 

Li Fanxi edited comment on SOLR-792 at 10/19/11 9:57 AM:
---------------------------------------------------------

I have a question about facet.pivot.mincount. Does this parameter defined as the limitation
for "minimum number of documents" that should be included in the result? 

In the current implementation, I found that this parameter also takes effect for the number
of facets fields, caused by the following code in doPivots function: 

{code}
    NamedList<Integer> nl = sf.getTermCounts(subField);
    if (nl.size() >= minMatch ) {
        pivot.add( "pivot", doPivots( nl, subField, nextField, fnames, rb, subset, minMatch
) );
        values.add( pivot ); // only add response if there are some counts
    }
{code} 

I don't understand why we need to compare minMatch to nl.size().

With this code, if we do pivot faceting on the fields "cat,manu_id_s", when cat='electronics'
and we have 50 documents distributed in 3 different "manu_id_s". If we limit the result with
facet.pivot.mincount=5, no result will be returned, because there are only 3 different "manu_id_s".
Is this the desired behavior for the "facet.pivot.mincount" parameter?

If this is not the desired behavior, what behavior it should be? My suggestion is to filter
the results only based on document count, and return both the actual number and the number
of document has been filtered by mincount parameter to the caller, and user can get the raw
data and define the behavior by themselves. 
                
      was (Author: lifanxi):
    I have a question about facet.pivot.mincount. Does this parameter defined as the limitation
for "minimum number of documents" that should be included in the result? 

In the current implementation, I found that this parameter also takes effect for the number
of facets fields, caused by the following code in doPivots function: 

{code}
    NamedList<Integer> nl = sf.getTermCounts(subField);
    if (nl.size() >= minMatch ) {
        pivot.add( "pivot", doPivots( nl, subField, nextField, fnames, rb, subset, minMatch
) );
        values.add( pivot ); // only add response if there are some counts
    }
{code} 

I don't understand why we need to compare minMatch to nl.size().

With this code, if we do pivot faceting on the fields "cat,manu_id_s", when cat='electronics'
and we have 50 documents distributed in 3 different "manu_id_s". If we limit the result with
facet.pivot.mincount=5, no result will be returned, because there are only 3 different "manu_id_s".
Is this the desired behavior for the "facet.pivot.mincount" parameter?
                  
> Pivot (ie: Decision Tree) Faceting Component
> --------------------------------------------
>
>                 Key: SOLR-792
>                 URL: https://issues.apache.org/jira/browse/SOLR-792
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Erik Hatcher
>            Assignee: Yonik Seeley
>            Priority: Minor
>         Attachments: SOLR-792-PivotFaceting.patch, SOLR-792-PivotFaceting.patch, SOLR-792-PivotFaceting.patch,
SOLR-792-PivotFaceting.patch, SOLR-792-as-helper-class.patch, SOLR-792-distributed.patch,
SOLR-792-raw-type.patch, SOLR-792.patch, SOLR-792.patch, SOLR-792.patch, SOLR-792.patch, SOLR-792.patch,
SOLR-792.patch, SOLR-792.patch
>
>
> A component to do multi-level faceting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message