lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3539) IndexFormatTooOld/NewExc should try to include fileName + directory when possible
Date Fri, 28 Oct 2011 19:55:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138694#comment-13138694
] 

Robert Muir commented on LUCENE-3539:
-------------------------------------

Some more thoughts:
* maybe IndexInput should have a ctor like IndexInput(String resourceDescription)
* then, in *all* error messages (e.g. read past EOF) we could include this, for better error
descriptions
* when directories call openInput they could pass whatever they want (e.g. filename), and
CFS could include the "real" file within cfs
* we could declare this as just an opaque string describing the indexinput (yeah and II could
use it in its toString() as well)
* if we do this, i think it should be non-null (e.g. in 3.x we add no-arg ctor that forwards
to "no additional details" or whatever)

If we did it consistently like this, i think it could improve error messages and debugging
and be a pretty clean change.
                
> IndexFormatTooOld/NewExc should try to include fileName + directory when possible
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-3539
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3539
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3539.patch
>
>
> (Spinoff from http://markmail.org/thread/t6s7nn3ve765nojc )
> When we throw a too old/new exc we should try to include the full path to the offending
file, if possible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message