Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 385B47AB5 for ; Fri, 30 Sep 2011 17:04:11 +0000 (UTC) Received: (qmail 93061 invoked by uid 500); 30 Sep 2011 17:04:09 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 92996 invoked by uid 500); 30 Sep 2011 17:04:09 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 92989 invoked by uid 99); 30 Sep 2011 17:04:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2011 17:04:09 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2011 17:04:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A6F272A2F73 for ; Fri, 30 Sep 2011 17:03:45 +0000 (UTC) Date: Fri, 30 Sep 2011 17:03:45 +0000 (UTC) From: "Martijn van Groningen (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <352180982.12006.1317402225685.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <67109119.7486.1312447887044.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118192#comment-13118192 ] Martijn van Groningen commented on LUCENE-3360: ----------------------------------------------- bq. That was the plan. But first we need to revert the current impl in trunk I think I missed that. Can you point to the code and svn revision in trunk? > Move FieldCache to IndexReader > ------------------------------ > > Key: LUCENE-3360 > URL: https://issues.apache.org/jira/browse/LUCENE-3360 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Martijn van Groningen > Fix For: 3.5, 4.0 > > Attachments: LUCENE-3360-3x.patch, LUCENE-3360-3x.patch, LUCENE-3360-3x.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch > > > Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. > * Add a new method to IndexReader that by default throws an UOE: > {code}public FieldCache getFieldCache(){code} > * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMap,Object>> to store entries. > * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. > This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org