Return-Path: 
 <dev-return-78580-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 794B68411
	for <apmail-lucene-dev-archive@www.apache.org>;
 Mon,  5 Sep 2011 19:14:35 +0000 (UTC)
Received: (qmail 13031 invoked by uid 500); 5 Sep 2011 19:14:34 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 12922 invoked by uid 500); 5 Sep 2011 19:14:33 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 12911 invoked by uid 99); 5 Sep 2011 19:14:33 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Sep 2011 19:14:33 +0000
X-ASF-Spam-Status: No, hits=-2000.5 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Sep 2011 19:14:30 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id F2E6359116
	for <dev@lucene.apache.org>; Mon,  5 Sep 2011 19:14:09 +0000 (UTC)
Date: Mon, 5 Sep 2011 19:14:09 +0000 (UTC)
From: "Juan Grande (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1611339080.17905.1315250049990.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <21895220.42311291921321287.JavaMail.jira@thor>
Subject: [jira] [Updated] (SOLR-2280) commitWithin ignored for a delete
 query
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juan Grande updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch

I'm submitting a patch that implements commitWithin on deletes. The patch is for the 3x branch.

Two things should be noted:
# The commit is fired even if the delete doesn't really delete any document.
# When using the BinaryUpdateRequestHandler the params of the UpdateRequest are loaded when parsing the docs. If the request doesn't include a docs list, then the params aren't loaded. I added a workaround for this, but SOLR-1164 should solve this problem definitely.


> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org