lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (LUCENE-3396) Make TokenStream Reuse Mandatory for Analyzers
Date Mon, 05 Sep 2011 09:46:09 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097076#comment-13097076
] 

Chris Male edited comment on LUCENE-3396 at 9/5/11 9:44 AM:
------------------------------------------------------------

Hi Uwe,

I originally had ReuseStrategy with a generic type but then decided it was overkill since
it only benefits implementations, not users of ReuseStrategy.  If we want the extra type safety,
I'll happily make the change.

      was (Author: cmale):
    Hi Uwe,

I originally had ReuseStrategy with a generic type but then decided it was overkill.  If we
want the extra type safety, I'll happily make the change.
  
> Make TokenStream Reuse Mandatory for Analyzers
> ----------------------------------------------
>
>                 Key: LUCENE-3396
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3396
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Chris Male
>         Attachments: LUCENE-3396-rab.patch, LUCENE-3396-rab.patch, LUCENE-3396-rab.patch,
LUCENE-3396-rab.patch
>
>
> In LUCENE-2309 it became clear that we'd benefit a lot from Analyzer having to return
reusable TokenStreams.  This is a big chunk of work, but its time to bite the bullet.
> I plan to attack this in the following way:
> - Collapse the logic of ReusableAnalyzerBase into Analyzer
> - Add a ReuseStrategy abstraction to Analyzer which controls whether the TokenStreamComponents
are reused globally (as they are today) or per-field.
> - Convert all Analyzers over to using TokenStreamComponents.  I've already seen that
some of the TokenStreams created in tests need some work to be reusable (even if they aren't
reused).
> - Remove Analyzer.reusableTokenStream and convert everything over to using .tokenStream
(which will now be returning reusable TokenStreams).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message