lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3416) Allow to pass an instance of RateLimiter to FSDirectory allowing to rate limit merge IO across several directories / instances
Date Tue, 06 Sep 2011 19:19:09 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098286#comment-13098286
] 

Simon Willnauer commented on LUCENE-3416:
-----------------------------------------

I see, I guess that is kind of overkill here. This patch looks fine to me though while I wonder
why this needs to be synchronized since we don't read it from a synced block. if you want
this to take immediate effect you should rather use volatile here? I doubt that this is necessary
in this context - I'd rather not invalidate a cache line for each IndexOutput creation.

> Allow to pass an instance of RateLimiter to FSDirectory allowing to rate limit merge
IO across several directories / instances
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3416
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Shay Banon
>         Attachments: LUCENE-3416.patch
>
>
> This can come in handy when running several Lucene indices in the same VM, and wishing
to rate limit merge across all of them.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message