lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2742) Add commitWithin to convenience signatures for SolrServer.add(..)
Date Mon, 05 Sep 2011 11:08:10 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097123#comment-13097123
] 

Chris Male commented on SOLR-2742:
----------------------------------

Hey Jan,

Looks great! +1 to committing to trunk and back porting.

Just one personal nitpick, if we're going to add Javadocs to the SolrServer methods, can we
add full javadocs?

> Add commitWithin to convenience signatures for SolrServer.add(..)
> -----------------------------------------------------------------
>
>                 Key: SOLR-2742
>                 URL: https://issues.apache.org/jira/browse/SOLR-2742
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: SolrJ, commitWithin
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2742.patch, SOLR-2742.patch
>
>
> Today you need to manually create an UpdateRequest in order to set the commitWithin value.
> We should provide an optional commitWithin parameter on all SolrServer.add(..) methods
as a convenience

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message