lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3480) refactoring of docvalues params in Codec.java
Date Fri, 30 Sep 2011 19:31:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118310#comment-13118310
] 

Simon Willnauer commented on LUCENE-3480:
-----------------------------------------

thank you for cleaning this up!
                
> refactoring of docvalues params in Codec.java
> ---------------------------------------------
>
>                 Key: LUCENE-3480
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3480
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3480.patch
>
>
> While working on LUCENE-2621 I am trying to do some cleanup of the Codec APIs, currently
Codec.java has a boolean for getDocValuesUseCFS()
> I think this is an impl detail that should not be in Codec.java: e.g. i might make a
SimpleText impl that uses only 1 file and then the param
> is awkward.
> So, instead I created Sep impls that dont use CFS (use separate files) and placed them
under the sep package, if you don't want to use
> CFS you can just use these implementations in your codec.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message