Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F04D7EB3 for ; Wed, 17 Aug 2011 22:53:19 +0000 (UTC) Received: (qmail 74571 invoked by uid 500); 17 Aug 2011 22:53:18 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 74508 invoked by uid 500); 17 Aug 2011 22:53:17 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 74501 invoked by uid 99); 17 Aug 2011 22:53:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2011 22:53:17 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.210.46] (HELO mail-pz0-f46.google.com) (209.85.210.46) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2011 22:53:09 +0000 Received: by pzk32 with SMTP id 32so1969240pzk.19 for ; Wed, 17 Aug 2011 15:52:49 -0700 (PDT) Received: by 10.142.136.8 with SMTP id j8mr13613wfd.49.1313621568784; Wed, 17 Aug 2011 15:52:48 -0700 (PDT) Received: from bester.local ([65.78.136.75]) by mx.google.com with ESMTPS id f8sm962383pbk.6.2011.08.17.15.52.46 (version=SSLv3 cipher=OTHER); Wed, 17 Aug 2011 15:52:47 -0700 (PDT) Date: Wed, 17 Aug 2011 15:52:45 -0700 (PDT) From: Chris Hostetter To: dev@lucene.apache.org Subject: Re: Solr QueryResultKey hashCode() and equals() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII : with cache warming in Solr I found that the order of the Query objects : within the filters list makes a difference to the equals() and hashCode() : methods. ... : I found that it resulted in a cache miss for two queries that have the same : results just because the filters had a different ordering. Am I missing : something or is there an opportunity to improve the chance of matching cache : entries? I haven't dug into the code, but i suspect you are probably correct. Please open an issue drawing attention to this, but off the top of my head I'm not sure if there is a practical solution inside Solr -- Query classes aren't Comparable, so we can't do anythin simple like sort the List when executing the query or building the cache key. -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org