Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F31EA8868 for ; Sun, 14 Aug 2011 13:47:53 +0000 (UTC) Received: (qmail 81391 invoked by uid 500); 14 Aug 2011 13:47:50 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 80884 invoked by uid 500); 14 Aug 2011 13:47:50 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 80867 invoked by uid 99); 14 Aug 2011 13:47:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Aug 2011 13:47:48 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Aug 2011 13:47:47 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 30841BC95A for ; Sun, 14 Aug 2011 13:47:27 +0000 (UTC) Date: Sun, 14 Aug 2011 13:47:27 +0000 (UTC) From: "Chris Male (JIRA)" To: dev@lucene.apache.org Message-ID: <933017900.37199.1313329647195.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1061334343.7576.1309482388854.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (LUCENE-3271) Move 'good' contrib/queries classes to Queries module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Male updated LUCENE-3271: ------------------------------- Attachment: LUCENE-3271-regex.patch Back on the wagon again. Patch moves the regex.* to the queries module. Command coming up. Everything compiles, passes. > Move 'good' contrib/queries classes to Queries module > ----------------------------------------------------- > > Key: LUCENE-3271 > URL: https://issues.apache.org/jira/browse/LUCENE-3271 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Chris Male > Attachments: LUCENE-3271-MLT.patch, LUCENE-3271-MLT.patch, LUCENE-3271-regex.patch > > > With the Queries module now filled with the FunctionQuery stuff, we should look at closing down contrib/queries. While not a huge contrib, it contains a number of pretty useful classes and some that should go elsewhere. > Heres my proposed plan: > - similar.* -> suggest module > - regex.* -> queries module > - BooleanFilter -> queries module under .filters package > - BoostingQuery -> queries module > - ChainedFilter -> queries module under .filters package > - DuplicateFilter -> queries module under .filters package > - FieldCacheRewriteMethod -> This doesn't belong in this contrib or the queries module. I think we should push it to contrib/misc for the time being. It seems to have quite a few constraints on when its useful. If indeed CONSTANT_SCORE_AUTO rewrite is better, then I dont see a purpose for it. > - FilterClause -> class inside BooleanFilter > - FuzzyLikeThisQuery -> suggest module. This class seems a mess with its Similarity hardcoded. With all that said, it does seem to do what it claims and with some cleanup, it could be good. > - TermsFilter -> queries module under .filters package > - SlowCollated* -> They can stay in the module till we have a better place to nuke them. > One of the implications of the above moves, is that the xml-query-parser, which supports many of the queries, will need to have a dependency on the queries module. But that seems unavoidable at this stage. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org