Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 803467D66 for ; Wed, 17 Aug 2011 12:25:25 +0000 (UTC) Received: (qmail 57967 invoked by uid 500); 17 Aug 2011 12:25:20 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 56949 invoked by uid 500); 17 Aug 2011 12:25:11 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 56924 invoked by uid 99); 17 Aug 2011 12:25:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2011 12:25:09 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2011 12:25:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 45ADCC0C70 for ; Wed, 17 Aug 2011 12:24:46 +0000 (UTC) Date: Wed, 17 Aug 2011 12:24:46 +0000 (UTC) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Message-ID: <1988678025.44810.1313583886282.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <67109119.7486.1312447887044.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086260#comment-13086260 ] Robert Muir commented on LUCENE-3360: ------------------------------------- {quote} For the new IR.getFieldCache() instead of a "generic" UOE can we throw something like MR.fields() throws? Ie the exc message should explain that you should use the SlowMRWrapper instead. {quote} Yeah, can we force the user to make their own SlowMultiReaderWrapper? I don't think we should ever create such things, even for deprecated stuff in 4.0 In 4.0 we just change the API and make you create it yourself. > Move FieldCache to IndexReader > ------------------------------ > > Key: LUCENE-3360 > URL: https://issues.apache.org/jira/browse/LUCENE-3360 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Martijn van Groningen > Fix For: 3.4, 4.0 > > Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch > > > Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. > * Add a new method to IndexReader that by default throws an UOE: > {code}public FieldCache getFieldCache(){code} > * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMap,Object>> to store entries. > * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. > This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org