Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 34D4D755B for ; Sun, 7 Aug 2011 22:30:53 +0000 (UTC) Received: (qmail 26543 invoked by uid 500); 7 Aug 2011 22:30:51 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 26453 invoked by uid 500); 7 Aug 2011 22:30:50 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 26446 invoked by uid 99); 7 Aug 2011 22:30:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2011 22:30:50 +0000 X-ASF-Spam-Status: No, hits=-2000.8 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2011 22:30:49 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 12808B0910 for ; Sun, 7 Aug 2011 22:30:29 +0000 (UTC) Date: Sun, 7 Aug 2011 22:30:29 +0000 (UTC) From: "Mark Miller (JIRA)" To: dev@lucene.apache.org Message-ID: <1909119848.15192.1312756229072.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1688236302.15468.1310686679848.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (SOLR-2654) not used consistently in all places Directory objects are instantiated MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080687#comment-13080687 ] Mark Miller commented on SOLR-2654: ----------------------------------- So I removed the close directories hack for tests and realized that I need the solution I proposed above regardless - when we force open a new directory, we need to close the old one - because we replace it in the map (well, close it, or keep it around in another list/set). We cannot close it right then, because something still might be using it. The ref cnt dir is def coming back. > not used consistently in all places Directory objects are instantiated > ---------------------------------------------------------------------------------- > > Key: SOLR-2654 > URL: https://issues.apache.org/jira/browse/SOLR-2654 > Project: Solr > Issue Type: Bug > Reporter: Hoss Man > Assignee: Mark Miller > Fix For: 3.4, 4.0 > > Attachments: SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch > > > nipunb noted on the mailing list then when configuring solr to use an alternate (ie: simple) the stats for the SolrIndexSearcher list NativeFSLockFactory being used by the Directory. > The problem seems to be that SolrIndexConfig is not consulted when constructing Directory objects used for IndexReader (it's only used by SolrIndexWriter) > I don't _think_ this is a problem in most cases since the IndexReaders should all be readOnly in the core solr code) but plugins could attempt to use them in other ways. In general it seems like a really bad bug waiting to happen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org