Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C4D2883E for ; Sun, 28 Aug 2011 21:19:04 +0000 (UTC) Received: (qmail 82124 invoked by uid 500); 28 Aug 2011 21:19:03 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 82009 invoked by uid 500); 28 Aug 2011 21:19:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 81999 invoked by uid 99); 28 Aug 2011 21:19:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Aug 2011 21:19:01 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Aug 2011 21:18:59 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A992BD4213 for ; Sun, 28 Aug 2011 21:18:38 +0000 (UTC) Date: Sun, 28 Aug 2011 21:18:38 +0000 (UTC) From: "Martijn van Groningen (JIRA)" To: dev@lucene.apache.org Message-ID: <1500825325.1495.1314566318691.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <67109119.7486.1312447887044.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (LUCENE-3360) Move FieldCache to IndexReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-3360: ------------------------------------------ Attachment: LUCENE-3360.patch Updated patch to latest changes in trunk. I'm busy with the 3x backport, but since the FieldCacheImpl versions between trunk and 3x it took me longer than I expected. I think once the 3x version is ready (coming days or so) we can commit this patch also. After that we can work towards removing the current FC from trunk and moving the classes inside FieldCache class to proper locations (like search.cache package). > Move FieldCache to IndexReader > ------------------------------ > > Key: LUCENE-3360 > URL: https://issues.apache.org/jira/browse/LUCENE-3360 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Martijn van Groningen > Fix For: 3.4, 4.0 > > Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch > > > Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. > * Add a new method to IndexReader that by default throws an UOE: > {code}public FieldCache getFieldCache(){code} > * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMap,Object>> to store entries. > * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. > This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org