Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53FD38ED8 for ; Wed, 31 Aug 2011 00:59:35 +0000 (UTC) Received: (qmail 37173 invoked by uid 500); 31 Aug 2011 00:59:33 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 37106 invoked by uid 500); 31 Aug 2011 00:59:33 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 36934 invoked by uid 99); 31 Aug 2011 00:59:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2011 00:59:32 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2011 00:59:30 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 74C264187D for ; Wed, 31 Aug 2011 00:59:10 +0000 (UTC) Date: Wed, 31 Aug 2011 00:59:10 +0000 (UTC) From: "Kim Taylor (JIRA)" To: dev@lucene.apache.org Message-ID: <1246280329.801.1314752350475.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (SOLR-752) Allow better Field Compression options MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094219#comment-13094219 ] Kim Taylor commented on SOLR-752: --------------------------------- I've had a look into this. Simon is right, DefaultSolrHighlighter uses doc.getValues(fieldName) to retrieve the field. lucene.document.Document.getValues() calls stringValue on the appropriate field. The problem is that when FieldsWriter/Reader read fields from segments, the supplied CompressedField gets converted into a Field, which does not know how to interpret fieldsData. I've added another patch that alters DefaultSolrHighlighter to use the schema FieldType (in this case CompressedField) to properly interpred fieldsData. > Allow better Field Compression options > -------------------------------------- > > Key: SOLR-752 > URL: https://issues.apache.org/jira/browse/SOLR-752 > Project: Solr > Issue Type: Improvement > Reporter: Grant Ingersoll > Priority: Minor > Attachments: compressedtextfield.patch > > > See http://lucene.markmail.org/message/sd4mgwud6caevb35?q=compression > It would be good if Solr handled field compression outside of Lucene's Field.COMPRESS capabilities, since those capabilities are less than ideal when it comes to control over compression. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org