Return-Path: 
 <dev-return-76827-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 715B17B02
	for <apmail-lucene-dev-archive@www.apache.org>;
 Wed,  3 Aug 2011 12:46:51 +0000 (UTC)
Received: (qmail 98049 invoked by uid 500); 3 Aug 2011 12:46:50 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 97866 invoked by uid 500); 3 Aug 2011 12:46:49 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 97859 invoked by uid 99); 3 Aug 2011 12:46:49 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2011 12:46:49 +0000
X-ASF-Spam-Status: No, hits=-2000.7 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2011 12:46:47 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 19DE1A6B42
	for <dev@lucene.apache.org>; Wed,  3 Aug 2011 12:46:27 +0000 (UTC)
Date: Wed, 3 Aug 2011 12:46:27 +0000 (UTC)
From: "Mark Miller (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1010176034.4557.1312375587102.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1617349788.3368.1312330587167.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2691) solr.xml persistence is broken for
 multicore (by SOLR-2331)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/SOLR-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078719#comment-13078719 ] 

Mark Miller commented on SOLR-2691:
-----------------------------------

Thanks a lot for the catch and diagnosis Yury - hossman tends to sleep all day, but when he gets up and delivers his patch, we will get this in right away.

> solr.xml persistence is broken for multicore (by SOLR-2331)
> -----------------------------------------------------------
>
>                 Key: SOLR-2691
>                 URL: https://issues.apache.org/jira/browse/SOLR-2691
>             Project: Solr
>          Issue Type: Bug
>          Components: multicore
>    Affects Versions: 4.0
>            Reporter: Yury Kats
>            Assignee: Mark Miller
>            Priority: Critical
>             Fix For: 4.0
>
>         Attachments: SOLR-2691.patch, jira2691.patch
>
>
> With the trunk build, running SolrCloud, if I issue a PERSIST CoreAdmin command,
> the solr.xml gets overwritten with only the last core, repeated as many times
> as there are cores.
> It used to work fine with a trunk build from a couple of months ago, so it looks like
> something broke solr.xml persistence. 
> It appears to have been introduced by SOLR-2331:
> CoreContainer#persistFile creates the map for core attributes (coreAttribs) outside 
> of the loop that iterates over cores. Therefore, all cores reuse the same map of attributes
> and hence only the values from the last core are preserved and used for all cores in the list.
> I'm running SolrCloud, using:
> -Dbootstrap_confdir=/opt/solr/solr/conf -Dcollection.configName=hcpconf -DzkRun
> I'm starting Solr with four cores listed in solr.xml:
> <solr persistent="true">
>   <cores adminPath="/admin/cores" defaultCoreName="master1">
>     <core name="master1" instanceDir="master1" shard="shard1" collection="hcpconf" />
>     <core name="master2" instanceDir="master2" shard="shard2" collection="hcpconf" />
>     <core name="slave1" instanceDir="slave1" shard="shard1" collection="hcpconf" />
>     <core name="slave2" instanceDir="slave2" shard="shard2" collection="hcpconf" />
>   </cores>
> </solr>
> I then issue a PERSIST request:
> http://localhost:8983/solr/admin/cores?action=PERSIST
> And the solr.xml turns into:
> <solr persistent="true">
>   <cores defaultCoreName="master1" adminPath="/admin/cores" zkClientTimeout="10000" hostPort="8983" hostContext="solr">
>     <core shard="shard2" instanceDir="slave2/" name="slave2" collection="hcpconf"/>
>     <core shard="shard2" instanceDir="slave2/" name="slave2" collection="hcpconf"/>
>     <core shard="shard2" instanceDir="slave2/" name="slave2" collection="hcpconf"/>
>     <core shard="shard2" instanceDir="slave2/" name="slave2" collection="hcpconf"/>
>   </cores>
> </solr>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org