lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Updated] (SOLR-2565) Prevent IW#close and cut over to IW#commit
Date Wed, 24 Aug 2011 18:08:31 GMT


Hoss Man updated SOLR-2565:

    Attachment: SOLR-2565__HuperDuperAutoCommitTest.patch

As mark mentioned, i started looking into a better overall meme for testing autocommit --
i could never reproduce any of the failures charlie cron was complaining about, but the tests
didn't make any sense to me anyway.

path demonstrates a new overall approach, using more detailed monitor of events -- not just
"the most recent event" but all of them in a queue of (rough) timestamps.

at the moment one of the tests has an @Ignore:nocommit because of the delete bug that miller
mentioned, but it would be helpful to know if people who were seeing problems running AutoCOmmitTest.testSoftAndHardCommitMaxTime
(ie: charlie cron and simon) could try this patch out and see if it works better for them.

> Prevent IW#close and cut over to IW#commit
> ------------------------------------------
>                 Key: SOLR-2565
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Mark Miller
>             Fix For: 4.0
>         Attachments: SOLR-2565-revert.patch, SOLR-2565.patch, SOLR-2565.patch, SOLR-2565.patch,
SOLR-2565__HuperDuperAutoCommitTest.patch, dump.txt, slowtests.txt
> Spinnoff from SOLR-2193. We already have a branch to work on this issue here

> The main goal here is to prevent solr from closing the IW and use IW#commit instead.
AFAIK the main issues here are:
> The update handler needs an overhaul.
> A few goals I think we might want to look at:
> 1. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what
we now do with special casing:
> 2. Stop closing the IndexWriter and start using commit (still lazy IW init though).
> 3. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
> 4. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.
> Eventually this is a preparation for NRT support in Solr which I will create a followup
issue for.

This message is automatically generated by JIRA.
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message