lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3330) revise Scorer visitor API
Date Mon, 15 Aug 2011 13:47:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085085#comment-13085085
] 

Michael McCandless commented on LUCENE-3330:
--------------------------------------------

I like this simplification!  I agree baking in BQ's relationships into this Scorer API is
not good, and it's better to let the caller decide how/when/what subs to visit.

+1 to commit

> revise Scorer visitor API
> -------------------------
>
>                 Key: LUCENE-3330
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3330
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3330.patch
>
>
> Currently there is an (expert) API in scorer to allow you to take a scorer, and visit
its children etc (e.g. booleanquery).
> I think we should improve this, so its general to all queries.
> The current issues are:
> * the current api is hardcoded for booleanquery's Occurs, but we should support other
types of children (e.g. disjunctionmax)
> * it can be difficult to use the API, because of the amount of generics and the visitor
callback API. 
> * the current API enforces a DFS traversal when you might prefer BFS instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message