lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3408) Remove unnecessary memory barriers in DWPT
Date Wed, 31 Aug 2011 10:01:10 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094406#comment-13094406
] 

Michael McCandless commented on LUCENE-3408:
--------------------------------------------

Looks good Simon!  Have you tested perf...?  Likely minor but you never know :)

> Remove unnecessary memory barriers in DWPT
> ------------------------------------------
>
>                 Key: LUCENE-3408
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3408
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3408.patch
>
>
> Currently DWPT still uses AtomicLong to count the bytesUsed. Each write access issues
an implicite memory barrier which is totally unnecessary since we doing everything single
threaded on that level. This might be very minor but we shouldn't issue unnecessary memory
barriers causing processors to lock their instruction pipeline for no reason.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message