Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A497E7FF8 for ; Sat, 30 Jul 2011 18:26:35 +0000 (UTC) Received: (qmail 13782 invoked by uid 500); 30 Jul 2011 18:26:34 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 13630 invoked by uid 500); 30 Jul 2011 18:26:33 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 13612 invoked by uid 99); 30 Jul 2011 18:26:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Jul 2011 18:26:33 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Jul 2011 18:26:30 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8427C95E3D for ; Sat, 30 Jul 2011 18:26:09 +0000 (UTC) Date: Sat, 30 Jul 2011 18:26:09 +0000 (UTC) From: "Yonik Seeley (JIRA)" To: dev@lucene.apache.org Message-ID: <795212545.21061.1312050369538.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1879255020.19751.1311970330801.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (SOLR-2685) always use SolrInputDocument MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-2685: ------------------------------- Attachment: SOLR-2685.patch Here's a patch that implements the above, in addition to moving from String to BytesRef for getIndexedId() and some other misc cleanups. > always use SolrInputDocument > ---------------------------- > > Key: SOLR-2685 > URL: https://issues.apache.org/jira/browse/SOLR-2685 > Project: Solr > Issue Type: Improvement > Reporter: Yonik Seeley > Priority: Minor > Attachments: SOLR-2685.patch > > > First, there was only Document, then AddUpdateCommand added support for SolrInputDocument, and most document producers create SolrInputDocuments. But AddUpdateCommand continues to support both, leading to confusion and more work for update processors (which should they look at? both?). It seems like we should remove "Document" from AddUpdateCommand for the sake of consistency. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org