Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sat, 9 Jul 2011 00:20:17 +0000 (UTC)
From: "Ryan McKinley (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <356148644.13107.1310170817198.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <240221985.187.1309861637259.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2633) Make SolrDispatchFilter testable and
 add tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062261#comment-13062261 ] 

Ryan McKinley commented on SOLR-2633:
-------------------------------------

Oh man... SOLR-104!

The key reason was backwards compatibility.  At the time there was a servlet mapping /select  --  Changing to a filter let us map /* and optionally override the leggacy servlet if that was configured in solrconfg (handleSelect=true)


> Make SolrDispatchFilter testable and add tests
> ----------------------------------------------
>
>                 Key: SOLR-2633
>                 URL: https://issues.apache.org/jira/browse/SOLR-2633
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1, 3.2, 3.3
>            Reporter: Edoardo Tosca
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch
>
>
> I have ideas for possible extensions/enhancements to the SolrDispatchFilter. However, as it doesn't have any tests, making safe enhancements is difficult. Given its monolithic nature, it is hard to test. Therefore, I am proposing to refactor it to make it testable, and to provide tests for it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org