Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 4 Jul 2011 06:20:22 +0000 (UTC)
From: "Adriano Crestani (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1123061160.1367.1309760422094.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1663956819.59.1300687385841.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LUCENE-2979) Simplify configuration API of
 contrib Query Parser
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059329#comment-13059329 ] 

Adriano Crestani commented on LUCENE-2979:
------------------------------------------

Hi Phillipe, thanks for the patch. However, as you did many changes to javadocs, I decided to run "ant javadocs" and it fails. It seems your patch references many times the constants in StandardQueryConfigHandler.ConfigurationKeys using @see tag, unfortunately you forgot to create a javadoc for those constants and it's causing the ant script to fail. Please, add these missing javadocs, run ant javadocs on contrib/queryparser to check if it finishes successfully and then submit a new patch.

Besides that, great job, tests are running fine even after your big change :)

Thanks!

> Simplify configuration API of contrib Query Parser
> --------------------------------------------------
>
>                 Key: LUCENE-2979
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2979
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 2.9, 3.0
>            Reporter: Adriano Crestani
>            Assignee: Adriano Crestani
>              Labels: api-change, gsoc, gsoc2011, lucene-gsoc-11, mentor
>             Fix For: 3.4, 4.0
>
>         Attachments: LUCENE-2979_phillipe_ramalho_2.patch, LUCENE-2979_phillipe_reamalho.patch
>
>
> The current configuration API is very complicated and inherit the concept used by Attribute API to store token information in token streams. However, the requirements for both (QP config and token stream) are not the same, so they shouldn't be using the same thing.
> I propose to simplify QP config and make it less scary for people intending to use contrib QP. The task is not difficult, it will just require a lot of code change and figure out the best way to do it. That's why it's a good candidate for a GSoC project.
> I would like to hear good proposals about how to make the API more friendly and less scaring :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org