Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: "Uwe Schindler" <uwe@thetaphi.de>
To: <dev@lucene.apache.org>
References: <673ED01A-D2F3-4516-B5F6-633E202BEFF7@mitre.org>
 <CAOdYfZX494CRv9ESvk2wHt_Qb8hcRyUjmRDYRPC3QnZPCt+p2g@mail.gmail.com>
 <9B3E4AE0-2D13-407B-83F9-69834B0D052A@mitre.org>
In-Reply-To: <9B3E4AE0-2D13-407B-83F9-69834B0D052A@mitre.org>
Subject: RE: FindBugs & PMD ?
Date: Fri, 8 Jul 2011 19:16:19 +0200
Message-ID: <001b01cc3d92$c13e0ad0$43ba2070$@thetaphi.de>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQGRW+tVd/Pn7SOpMGaokd8KF04i3gDmK2/aA0TLB1OVNxWngA==
Content-Language: de

Just a stupid question:
Once you add those annotations, wouldn't the JAR file not require then this
annotations.jar? Or are all of them not available to runtime?

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de

> -----Original Message-----
> From: Smiley, David W. [mailto:dsmiley@mitre.org]
> Sent: Friday, July 08, 2011 4:30 PM
> To: dev@lucene.apache.org
> Subject: Re: FindBugs & PMD ?
> 
> Rob, there is an ASL 2.0 licensed implementation here:
> https://github.com/stephenc/findbugs-annotations
> 
> ~ David
> 
> On Jul 8, 2011, at 10:12 AM, Robert Muir wrote:
> 
> > On Fri, Jul 8, 2011 at 10:08 AM, Smiley, David W. <dsmiley@mitre.org>
> wrote:
> >> Developers,
> >> Any thoughts on using FindBugs & PMD to catch more bugs in
> Lucene/Solr?  Jenkins could be configured to run FindBugs & PMD analysis
> nightly.  It would have helped find this:
> >>
> >>         (LUCENE-3294) Some code still compares string equality
> >> instead using equals
> >>
> >> I am aware there are a high degree of false-positives but there are
ways
> of dealing with them, such as with @SuppressWarnings("PMD") and with
> //NOPMD   and for Findbugs, there is
> @edu.umd.cs.findbugs.annotations.SuppressWarnings(....)  and there's a
> fairly detailed configuration file for FindBugs to really control it and
to make
> exceptions.  I'd also really like to see use of FindBugs concurrency
> annotations @GuardedBy, @Immutable, @NotThreadSafe, @ThreadSafe.
> >
> > I think its a good idea for nightly, but I am strongly against linking
> > to an LGPL library for these annotations.
> > I would prefer PMD instead, because of the license.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > additional commands, e-mail: dev-help@lucene.apache.org
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org