lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: I really hate to even mention formatting code, but I don't want to gaffe too badly on my first commit.
Date Fri, 08 Jul 2011 21:14:23 GMT
On Fri, Jul 8, 2011 at 5:11 PM, Robert Muir <rcmuir@gmail.com> wrote:
> On Fri, Jul 8, 2011 at 5:06 PM, Erick Erickson <erickerickson@gmail.com> wrote:
>> This is one of those topics that generates far more passion than it
>> deserves, all I want to know is what the norms are. Personally, I tend
>> to reformat the entire file. But then I didn't cut my eye teeth on
>> code that a zillion other people work with and I fully appreciate that
>> the diffs get hard to read, you can't easily separate the code changes
>> from the format changes, so I'm not *proposing* reformatting the whole
>> file...
>>
>
> My opinion: just get rid of the shitty bad in whatever way is
> convenient for you.

+1

Mike McCandless

http://blog.mikemccandless.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message