lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Male <gento...@gmail.com>
Subject Re: QueryParser names
Date Wed, 06 Jul 2011 05:29:06 GMT
Hi Robert,

On Wed, Jul 6, 2011 at 5:19 PM, Robert Muir <rcmuir@gmail.com> wrote:

> Hi Chris,
>
> I hate to add confusion to this, but I wonder, do we have an idea how
> many modules will need to interact with a queryparser?
>

At a quick assessment, it seems only Solr will depend on the module.
 Currently the only other large user of the QPs is the highlighter tests.
 The rest of the dependencies are found in tests in a few modules/contribs,
which could be refactored out like I did for the core Lucene tests.


> If so, it might be worth making a simple abstract or even interface
> queryparser in core with something like Query parse(String text)
> throws ParseException
>
> This could be overkill, but it would allow modules that need to use
> this stuff to depend upon the interface, not the implementation...
> again feel free to ignore me, but this is how we pulled this off with
> Analyzer.
>
> Otherwise, another idea you could consider is naming the surround one
> SurroundQueryParser?
>

Sounds fine.  Any thoughts on what the call the existing Lucene core
QueryParser?


>
> On Wed, Jul 6, 2011 at 1:00 AM, Chris Male <gento0nz@gmail.com> wrote:
> > Hi,
> > I'm in the process of consolidating the various QueryParsers into a
> single
> > queryparser module and Ryan reminded me that the names of the QPs could
> > probably be clearer.  For example, we currently have two parsers called
> > QueryParser.  Given that the core QueryParser is no longer going to be in
> > core, I think it could do with a name that more accurately describes its
> > purpose.
> > Does anybody have any thoughts on how to name the following parsers:
> > org.apache.lucene.queryParser.QueryParser (lucene core)
> > org.apache.lucene.queryParser.surround.parser.QueryParser (queryparser
> > contrib)
> > org.apache.lucene.queryParser.standard.StandardQueryParser (queryparser
> > contrib)
> > Cheers
> > Chris
> > --
> > Chris Male | Software Developer | JTeam BV.| www.jteam.nl
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>


-- 
Chris Male | Software Developer | JTeam BV.| www.jteam.nl

Mime
View raw message