lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3295) BitVector never skips fully populated bytes when writing ClearedDgaps
Date Fri, 08 Jul 2011 19:05:16 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-3295:
---------------------------------------

    Attachment: LUCENE-3295.patch

Egads, thanks Simon!  I found a few more crazy problems with BitVector
(patch attached, merged with the first patch), and added some asserts
and a few more test cases.


> BitVector never skips fully populated bytes when writing ClearedDgaps
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-3295
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3295
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 3.4, 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: LUCENE-3295.patch, LUCENE-3295.patch
>
>
> When writing cleared DGaps in BitVector we compare a byte against 0xFF (255) yet the
byte is casted into an int (-1) and the comparison will never succeed. We should mask the
byte with 0xFF before comparing or compare against -1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message