lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler" <...@thetaphi.de>
Subject RE: FindBugs & PMD ?
Date Fri, 08 Jul 2011 17:16:19 GMT
Just a stupid question:
Once you add those annotations, wouldn't the JAR file not require then this
annotations.jar? Or are all of them not available to runtime?

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de

> -----Original Message-----
> From: Smiley, David W. [mailto:dsmiley@mitre.org]
> Sent: Friday, July 08, 2011 4:30 PM
> To: dev@lucene.apache.org
> Subject: Re: FindBugs & PMD ?
> 
> Rob, there is an ASL 2.0 licensed implementation here:
> https://github.com/stephenc/findbugs-annotations
> 
> ~ David
> 
> On Jul 8, 2011, at 10:12 AM, Robert Muir wrote:
> 
> > On Fri, Jul 8, 2011 at 10:08 AM, Smiley, David W. <dsmiley@mitre.org>
> wrote:
> >> Developers,
> >> Any thoughts on using FindBugs & PMD to catch more bugs in
> Lucene/Solr?  Jenkins could be configured to run FindBugs & PMD analysis
> nightly.  It would have helped find this:
> >>
> >>         (LUCENE-3294) Some code still compares string equality
> >> instead using equals
> >>
> >> I am aware there are a high degree of false-positives but there are
ways
> of dealing with them, such as with @SuppressWarnings("PMD") and with
> //NOPMD   and for Findbugs, there is
> @edu.umd.cs.findbugs.annotations.SuppressWarnings(....)  and there's a
> fairly detailed configuration file for FindBugs to really control it and
to make
> exceptions.  I'd also really like to see use of FindBugs concurrency
> annotations @GuardedBy, @Immutable, @NotThreadSafe, @ThreadSafe.
> >
> > I think its a good idea for nightly, but I am strongly against linking
> > to an LGPL library for these annotations.
> > I would prefer PMD instead, because of the license.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > additional commands, e-mail: dev-help@lucene.apache.org
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message