Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 234F14D0C for ; Tue, 21 Jun 2011 17:20:10 +0000 (UTC) Received: (qmail 17536 invoked by uid 500); 21 Jun 2011 17:20:08 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 17401 invoked by uid 500); 21 Jun 2011 17:20:08 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 17392 invoked by uid 99); 21 Jun 2011 17:20:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2011 17:20:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2011 17:20:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A5F564264F3 for ; Tue, 21 Jun 2011 17:19:47 +0000 (UTC) Date: Tue, 21 Jun 2011 17:19:47 +0000 (UTC) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Message-ID: <680027071.25007.1308676787676.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <783211145.24845.1308675587358.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Assigned] (LUCENE-3224) bugs in ByteArrayDataInput MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-3224: ------------------------------------------ Assignee: Michael McCandless > bugs in ByteArrayDataInput > -------------------------- > > Key: LUCENE-3224 > URL: https://issues.apache.org/jira/browse/LUCENE-3224 > Project: Lucene - Java > Issue Type: Bug > Reporter: Robert Muir > Assignee: Michael McCandless > Attachments: LUCENE-3224.patch > > > ByteArrayDataInput has a byte[] ctor, but it doesn't actually work (some things like readVint will work, others will fail due to asserts). > The problem is it doesnt set things like limit in the ctor... I think the ctor should call reset() > Most code using this passes null to the ctor to initialize it, then uses reset(), instead they could just call ByteArrayInput(BytesRef.EMPTY_BYTES) if they want to do that. > finally, reset()'s limit looks like it should be offset + len -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org