Return-Path: 
 <dev-return-73291-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D8C334EAC
	for <apmail-lucene-dev-archive@www.apache.org>;
 Fri, 17 Jun 2011 19:26:12 +0000 (UTC)
Received: (qmail 54117 invoked by uid 500); 17 Jun 2011 19:26:11 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 54030 invoked by uid 500); 17 Jun 2011 19:26:11 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 54011 invoked by uid 99); 17 Jun 2011 19:26:10 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2011 19:26:10 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2011 19:26:08 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 6BE0A41E582
	for <dev@lucene.apache.org>; Fri, 17 Jun 2011 19:25:47 +0000 (UTC)
Date: Fri, 17 Jun 2011 19:25:47 +0000 (UTC)
From: "Simon Willnauer (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1328811237.16069.1308338747438.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1385662103.1654.1307928232168.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2589) Commenting out  the <arr
 name="queries"> section in firstSearcher generates an NPE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/SOLR-2589?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13051=
271#comment-13051271 ]=20

Simon Willnauer commented on SOLR-2589:
---------------------------------------

Erick, good to see testing for this! :)
I wonder if you have an encoding problem I see a <?> in DirectoryFactory (D=
ir=EF=BF=BDctoryFactory) in your patch.
Regarding the one line change I wonder if you could pull the "queries" name=
d list only once, assign it to a local var and check the var for null. Tiny=
 safe but every bit counts.

rest looks good I look forward to more patches like that with more test cod=
e than actual changes.

> Commenting out  the <arr name=3D"queries"> section in firstSearcher gener=
ates an NPE
> -------------------------------------------------------------------------=
---------
>
>                 Key: SOLR-2589
>                 URL: https://issues.apache.org/jira/browse/SOLR-2589
>             Project: Solr
>          Issue Type: Bug
>         Environment: All
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Trivial
>         Attachments: SOLR-2589.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it=
's pretty harmless but easy to fix. I'll get it done as soon as I get my ac=
count set up.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org