lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <>
Subject [jira] [Updated] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document
Date Thu, 02 Jun 2011 12:42:47 GMT


Martijn van Groningen updated LUCENE-3099:

    Attachment: LUCENE-3099.patch

Attached an updated version of the patch with the Mike's points. When building the module
no generic warnings occur any more in the ant build. I also updated some documentation.

For AbstractAllGroupsCollector, can we impl the getGroupCount in
the base class as getGroups.size()?
Certainly! Much better. Since the method is syntactical sugar anyway.

> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>                 Key: LUCENE-3099
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch,
LUCENE-3099.patch, LUCENE-3099.patch
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override, then I think
we could refactor Solr over to the module, because it could do function queries and normal
queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own interesting
group values per document.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message