lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3186) DocValues type should be recored in FNX file to early fail if user specifies incompatible type
Date Thu, 09 Jun 2011 15:14:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046604#comment-13046604
] 

Robert Muir commented on LUCENE-3186:
-------------------------------------

{quote}
So, I think the first question here is: which cases should be merged
"properly" and which should be considered "an error"? Probably we have
to work out the full matrix...
{quote}

this is all implementation details of docvalues, that it must deal with during merging.
I think it should work out the "LCD" and merge to that.

This is no different than if i have a field with all 8 character terms and then i add a 10-character
term,
sure my impl/codec's encoding could internally rely upon the the fact all terms are 8 chars,
but it must transparently change
its encoding to then support both 8 and 10 character terms and not throw an error.

If you mix up your doc values with ints and floats and bytes, isnt the least common denominator
always bytes?
(just encode the int as 4 bytes or whatever).

So in other words, i think its up to docvalues to change its encoding to support the LCD,
which might mean
downgrading ints to bytes or whatever, my only opinion is that it should never 'create' data
(this was my issue with fake norms,
lets not do that).


> DocValues type should be recored in FNX file to early fail if user specifies incompatible
type
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3186
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3186
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>
> Currently segment merger fails if the docvalues type is not compatible across segments.
We already catch this problem if somebody changes the values type for a field within one segment
but not across segments. in order to do that we should record the type in the fnx fiel alone
with the field numbers.
> I marked this 4.0 since it should not block the landing on trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message