lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2586) example work & logs directories needed?
Date Thu, 23 Jun 2011 03:38:47 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053632#comment-13053632
] 

David Smiley commented on SOLR-2586:
------------------------------------

bq. But i see you only targeting empty directories, which cause little confusion at all.

It's what had my attention at the time due to combination of writing about them and working
with git. The other possible improvements you mention sound good to me too.

I'll create a separate issue for git for .gitignore.  But I wanted to first figure out here
if those empty directories needed to be there in the first place.  "work" does, "log"... ?
Arguably not.  I think a little tolerance in the ant "example" target to needing to create
these directories is preferable to adding special hidden files, which always seem to be a
bit of a kluge.

> example work & logs directories needed?
> ---------------------------------------
>
>                 Key: SOLR-2586
>                 URL: https://issues.apache.org/jira/browse/SOLR-2586
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: David Smiley
>            Priority: Minor
>
> Firstly, what prompted this issue was me wanting to use a git solr mirror but finding
that git's lack of empty-directory support made the "example" ant task fail. This task requires
examples/work to be in place so that it can delete its contents. Fixing this was a simple
matter of adding:
> {code:xml}
> <mkdir dir="${example}/work" /><!-- in case not there -->
> {code}
> Right before the delete task.
> But then it occurred to me, why even have a "work" directory since Jetty will apparently
use a temp directory instead. -- try for yourself (stdout snippet):
> bq. 2011-06-11 00:51:26.177:INFO::Extract file:/SmileyDev/Search/lucene-solr/solr/example/webapps/solr.war
to /var/folders/zo/zoQJvqc9E0076p0THiri+k+++TI/-Tmp-/Jetty_0_0_0_0_8983_solr.war__solr__k1kf17/webapp
> On my Mac, this same directory was used for multiple runs, so somehow Jetty or the VM
figures out how to reuse it.
> Since this "example" setup isn't a *real* installation -- it's just for demonstration,
arguably it should not contain what it doesn't need.  Likewise, perhaps the empty example/logs
directory should be deleted. It's not used by default any way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message