lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3264) crank up faceting module tests
Date Thu, 30 Jun 2011 08:12:28 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057668#comment-13057668
] 

Shai Erera commented on LUCENE-3264:
------------------------------------

Patch looks very good. All tests pass for me (I've applied on trunk only).

Few things I've noticed:
* Previously the tests took 1m20s to run, now they take 2m55s. I guess it's because previously
we only created RAMDirs, while now newDirectory picks FSDir from time to time (10%?).

* FacetTestUtils.close*() can be removed and calls replaced by IOUtils.closeSafely. This is
not critical, just remove redundant code.

* You added a TODO to CategoryListIteratorTest about the test failing if TieredMP is used.
In general TieredMP is not good for the taxonomy index, which relies on Lucene doc IDs, and
therefore segments must be merged in-order. LTW uses LMP specifically because of that. I will
look into the test to understand why would it care about doc IDs, since it doesn't using the
taxonomy index at all.

* There are few places with code like: assertTrue("Would like to test this with deletions!",indexReader.hasDeletions()),
and assertTrue("Would like to test this with deletions!",indexReader.numDeletedDocs() >
0) which you removed. Any reason?

* You added a TODO to TestScoredDocIDsUtils (about reader is read-only) -- you're right, the
comment can be deleted.

While I reviewed, I was thinking that RandomIndexWriter is used to replace the IndexWriter
for content indexing. While this is good, this does not cover the 'taxonomy' indexing. So
I wonder if we should have under facet/test/o.a.l.utils a RandomTaxonomyWriter which opens
RIW internally?

This is very impressive progress Robert, thanks for doing it !

I am +1 to commit, after we resolve the tiny issues I raised above. We can add RandomTaxonomyWriter
as a follow-on commit.

> crank up faceting module tests
> ------------------------------
>
>                 Key: LUCENE-3264
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3264
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: modules/facet
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.4, 4.0
>
>         Attachments: LUCENE-3264.patch
>
>
> The faceting module has a large set of good tests.
> lets switch them over to use all of our test infra (randomindexwriter, random iwconfig,
mockanalyzer, newDirectory, ...)
> I don't want to address multipliers and atLeast() etc on this issue, I think we should
follow up with that on a separate issue, that also looks at speed and making sure the nightly
build is exhaustive.
> for now, lets just get the coverage in, it will be good to do before any refactoring.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message