lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-2564) Integrating grouping module into Solr 4.0
Date Fri, 03 Jun 2011 20:40:47 GMT

     [ https://issues.apache.org/jira/browse/SOLR-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated SOLR-2564:
-------------------------------------

    Attachment: LUCENE-2564.patch


Patch looks great!

Attached new patch with minor fixes:

  * I had to fixup Solr's common-build.xml (it was referencing
    lucene/contrib/grouping from 3.x).  After that all tests pass.

  * Fixed jdocs for GroupParams.GROUP_CACHE (we now default to true
    not false, right?)

I think GroupParams.GROUP_FACETS (group.docSet request param) is
unused?  Should we remove it?  (This is for when we do LUCENE-3097, I
think?)

So this cutover improves Solr trunk grouping's impl by adding option
to get total group count (group.totalCount request param) and using
the CachingCollector for fast replaying of hits for 2nd pass collector
(adds group.cache/group.cache.maxSizeMB request params).  The
double-RAM issue is fixed, thanks to LUCENE-3099.

So I think this is ready to be committed!!


> Integrating grouping module into Solr 4.0
> -----------------------------------------
>
>                 Key: SOLR-2564
>                 URL: https://issues.apache.org/jira/browse/SOLR-2564
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>             Fix For: 4.0
>
>         Attachments: LUCENE-2564.patch, SOLR-2564.patch, SOLR-2564.patch
>
>
> Since work on grouping module is going well. I think it is time to wire this up in Solr.
> Besides the current grouping features Solr provides, Solr will then also support second
pass caching and total count based on groups.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message