lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2586) example work & logs directories needed?
Date Mon, 13 Jun 2011 14:43:53 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048580#comment-13048580
] 

Robert Muir commented on SOLR-2586:
-----------------------------------

{quote}
shouldn't mean we can't recommend people use the WAR file and deploy it to a servlet engine
– generally speaking. Is Tomcat configured correctly a problem? Resin?
{quote}

Well, I would have a tough time recommending any of these servlet engines, not for any technical
reason, but just because we test with jetty in hudson, etc and deal with the issues that come
up. I'm sure in some special circumstances these alternative containers might have some value
that actually justifies "throwing away all the testing" we do here with Jetty... but still
thats a risk.

Yonik's link (SOLR-2158) is a good example, even if you were to change all the tests to work
with alternative servlet container X and run 'ant test', this doesn't mean a whole lot. That
particular bug was really difficult (impossible?) to reproduce and the reason we hit it is
continual testing.

Bottom line I think, is if someone wants to ensure that Solr works well on Tomcat for example,
then they should make a patch so that our tests test with this container too (e.g. in hudson,
etc). Once its baked in hudson for a while, then I would say its easy for us to recommend
it, too.

But in general, you won't hear me say "its just a war file, therefore it works with all containers".
Just like you won't hear me say "lucene is just a jar file, it works with all JREs": I do
run the lucene tests manually occasionally with BEA, IBM, etc but this is only sporatically,
nothing like running with these every 30 minutes and knocking out bugs.


> example work & logs directories needed?
> ---------------------------------------
>
>                 Key: SOLR-2586
>                 URL: https://issues.apache.org/jira/browse/SOLR-2586
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: David Smiley
>            Priority: Minor
>
> Firstly, what prompted this issue was me wanting to use a git solr mirror but finding
that git's lack of empty-directory support made the "example" ant task fail. This task requires
examples/work to be in place so that it can delete its contents. Fixing this was a simple
matter of adding:
> {code:xml}
> <mkdir dir="${example}/work" /><!-- in case not there -->
> {code}
> Right before the delete task.
> But then it occurred to me, why even have a "work" directory since Jetty will apparently
use a temp directory instead. -- try for yourself (stdout snippet):
> bq. 2011-06-11 00:51:26.177:INFO::Extract file:/SmileyDev/Search/lucene-solr/solr/example/webapps/solr.war
to /var/folders/zo/zoQJvqc9E0076p0THiri+k+++TI/-Tmp-/Jetty_0_0_0_0_8983_solr.war__solr__k1kf17/webapp
> On my Mac, this same directory was used for multiple runs, so somehow Jetty or the VM
figures out how to reuse it.
> Since this "example" setup isn't a *real* installation -- it's just for demonstration,
arguably it should not contain what it doesn't need.  Likewise, perhaps the empty example/logs
directory should be deleted. It's not used by default any way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message