lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3205) remove MultiTermQuery get/inc/clear totalNumberOfTerms
Date Wed, 15 Jun 2011 11:46:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049733#comment-13049733
] 

Uwe Schindler commented on LUCENE-3205:
---------------------------------------

I am perfectly fine to remove it. For analysis and debugging NRQ, it would still  be good
to have something, but I suggest to change the tests (I will simply request TermsEnum and
count terms, possibly on MultiTerms).

Should I take the issue and modify my tests?

> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
>                 Key: LUCENE-3205
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3205
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query. 
> All of these things add up to confusion, I think we should remove this 
> from multitermquery, the only thing that "uses" it is the NRQ tests, which 
> conditionalizes all the asserts anyway.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message