lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3206) FST package API refactoring
Date Thu, 16 Jun 2011 14:37:48 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050459#comment-13050459
] 

Michael McCandless commented on LUCENE-3206:
--------------------------------------------

This new FST API looks *sweet*!  Nice work :)

So with this we no longer need static Util methods right?  (Since each
arc can .follow a sequence of inputs).

I like OutputAlgebra ... better matches what this class actually does,
and if this means we can not create a new Object for every arc transition
that would be great (this makes FST lookups costly now).

I don't know if this is possible, but, one thing I don't like about
the current API is that the BYTE1/2/4 is an enum and not parameterized
into the Builder/FST.  Ie, Builder/FST should really take the input
type as a type param too, since really an FST acts like a SortedMap<K,V>.
But I fear this could get scary-hairy w/ the required generics...


> FST package API refactoring
> ---------------------------
>
>                 Key: LUCENE-3206
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3206
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/FSTs
>    Affects Versions: 3.2
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3206.patch
>
>
> The current API is still marked @experimental, so I think there's still time to fiddle
with it. I've been using the current API for some time and I do have some ideas for improvement.
This is a placeholder for these -- I'll post a patch once I have a working proof of concept.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message