Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of stachoo@gmail.com designates
 74.125.82.48 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type;
        b=ooPuQpPbzsPa7QzF5kT8RkMEefnZJquFvK5mwTsXhpCDbRCVme0bf4DwNwHmZpCSW+
         XGJunq0yi7pOiWX+npovLm59MjoxME5gKjwyll+JfLNyko7CkAySuN+AeoAranDfZY7n
         MFcrEVBZ0mgrrVmaBqFxG4LB37pZTqHoelEm0=
MIME-Version: 1.0
Sender: stachoo@gmail.com
In-Reply-To: 
 <2D127F11DC79714E9B6A43AC9458147FBAD4301B@suex07-mbx-03.ad.syr.edu>
References: 
 <2D127F11DC79714E9B6A43AC9458147FBAD42FCA@suex07-mbx-03.ad.syr.edu>
	<2D127F11DC79714E9B6A43AC9458147FBAD42FCD@suex07-mbx-03.ad.syr.edu>
	<2D127F11DC79714E9B6A43AC9458147FBAD42FD9@suex07-mbx-03.ad.syr.edu>
	<BANLkTikm2kVpSpsBN4B9efAR9uwi2Fw=tA@mail.gmail.com>
	<2D127F11DC79714E9B6A43AC9458147FBAD4301B@suex07-mbx-03.ad.syr.edu>
Date: Fri, 20 May 2011 20:57:54 +0200
Message-ID: <BANLkTinP=7dsg0cd+0TUP=9C1KgMKkFu-Q@mail.gmail.com>
Subject: Re: Branch 3.x build failure w/1.5: solr/contrib/clustering/ [was:
 [JENKINS-MAVEN] Lucene-Solr-Maven-3.x #128: POMs out of sync]
From: Stanislaw Osinski <stanislaw.osinski@carrotsearch.com>
To: dev@lucene.apache.org
Content-Type: multipart/alternative; boundary=0016e6d64c28003b0804a3b9b3c5

--0016e6d64c28003b0804a3b9b3c5
Content-Type: text/plain; charset=ISO-8859-1

>
> The jar checked into SVN, both on trunk and on branch_3x, is
> solr/contrib/clustering/lib/simple-xml-2.3.5.jar, which means that the Ant
> build is using this older version on both branches - shouldn't this also be
> upgraded to 2.4.1?
>

In fact, Solr clustering plugin just needs a number of annotations from that
JAR to compile, and these didn't change, so 2.3.5 should do the job just
fine.

> I'm assuming trunk does not suffer from this issue?
>
> Right, the official v3.5.0 carrot2-core POM includes the simple-xml
> dependency, while the Solr version (at
> solr/contrib/clustering/lib/solr-carrot2-core-pom.xml.template) does not (or
> did not, until you added it a few minutes ago).
>
> > One more thing: SimpleXML is required during compilation
> > (annotations), but it's not needed when running clustering
> > within Solr. So I think a dependency with the "compile"
> > scope should do too.
>
> I think "provided" scope is the one we want here, since we want to exclude
> it as a transitive dependency (just like the servlet-api jar):
>
> <
> http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope
> >
>

Good point! I've just made that change locally and it turns out that
"provided" is not transitive, so we'd need to add the dependency
to solr-clustering POM (instead of Carrot2's). I'm fine with either solution
(keeping SimpleXML in Carrot2 POM with the default scope or
in solr-clustering with provided scope), though I'm assuming the latter will
save the consumers one JAR in their classpaths. Just let me know which one
you'd prefer.

S.

--0016e6d64c28003b0804a3b9b3c5
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class=3D"im=
">The jar checked into SVN, both on trunk and on branch_3x, is solr/contrib=
/clustering/lib/simple-xml-2.3.5.jar, which means that the Ant build is usi=
ng this older version on both branches - shouldn&#39;t this also be upgrade=
d to 2.4.1?</div>
</blockquote><div><br></div><div>In fact, Solr clustering plugin just needs=
 a number of annotations from that JAR to compile, and these didn&#39;t cha=
nge, so 2.3.5 should do the job just fine.</div><div><br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid=
;padding-left:1ex;">

<div class=3D"im">&gt; I&#39;m assuming trunk does not suffer from this iss=
ue?<br>
<br>
</div>Right, the official v3.5.0 carrot2-core POM includes the simple-xml d=
ependency, while the Solr version (at solr/contrib/clustering/lib/solr-carr=
ot2-core-pom.xml.template) does not (or did not, until you added it a few m=
inutes ago).<br>

<div class=3D"im"><br>
&gt; One more thing: SimpleXML is required during compilation<br>
&gt; (annotations), but it&#39;s not needed when running clustering<br>
&gt; within Solr. So I think a dependency with the &quot;compile&quot;<br>
&gt; scope should do too.<br>
<br>
</div>I think &quot;provided&quot; scope is the one we want here, since we =
want to exclude it as a transitive dependency (just like the servlet-api ja=
r):<br>
<br>
&lt;<a href=3D"http://maven.apache.org/guides/introduction/introduction-to-=
dependency-mechanism.html#Dependency_Scope" target=3D"_blank">http://maven.=
apache.org/guides/introduction/introduction-to-dependency-mechanism.html#De=
pendency_Scope</a>&gt;<br>
</blockquote><div><br></div><div>Good point! I&#39;ve just made that change=
 locally and it turns out that &quot;provided&quot; is not transitive, so w=
e&#39;d need to add the dependency to=A0solr-clustering POM (instead of Car=
rot2&#39;s). I&#39;m fine with either solution (keeping SimpleXML in Carrot=
2 POM with the default scope or in=A0solr-clustering with provided scope), =
though I&#39;m assuming the latter will save the consumers one JAR in their=
 classpaths. Just let me know which one you&#39;d prefer.</div>
<div><br></div><div>S.</div></div>

--0016e6d64c28003b0804a3b9b3c5--