Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10B89277E for ; Thu, 5 May 2011 23:29:44 +0000 (UTC) Received: (qmail 14177 invoked by uid 500); 5 May 2011 23:29:42 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 14130 invoked by uid 500); 5 May 2011 23:29:42 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 14123 invoked by uid 99); 5 May 2011 23:29:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2011 23:29:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2011 23:29:41 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2BFDEC3EBB for ; Thu, 5 May 2011 23:29:03 +0000 (UTC) Date: Thu, 5 May 2011 23:29:03 +0000 (UTC) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Message-ID: <864454321.26604.1304638143176.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <418811680.15731.1299971219390.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (LUCENE-2966) SegmentReader.doCommit should be sync'd; norms methods need not be sync'd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-2966. ---------------------------------------- Resolution: Fixed > SegmentReader.doCommit should be sync'd; norms methods need not be sync'd > ------------------------------------------------------------------------- > > Key: LUCENE-2966 > URL: https://issues.apache.org/jira/browse/LUCENE-2966 > Project: Lucene - Java > Issue Type: Bug > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 3.2, 4.0 > > Attachments: LUCENE-2966.patch > > > I fixed the failure in TestNRTThreads, but in the process tripped an assert because SegmentReader.doCommit isn't sync'd. > So I sync'd it, but I don't think the norms APIs need to be sync'd -- we populate norms up front and then never change them. Un-sync'ing them is important so that in the NRT case calling IW.commit doesn't block searches trying to pull norms. > Also some small code refactoring. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org