Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 699DA40BD for ; Sun, 29 May 2011 18:44:30 +0000 (UTC) Received: (qmail 24258 invoked by uid 500); 29 May 2011 18:44:29 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 24195 invoked by uid 500); 29 May 2011 18:44:29 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 24188 invoked by uid 99); 29 May 2011 18:44:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 May 2011 18:44:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 May 2011 18:44:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 03285E703B for ; Sun, 29 May 2011 18:43:48 +0000 (UTC) Date: Sun, 29 May 2011 18:43:48 +0000 (UTC) From: "Shai Erera (JIRA)" To: dev@lucene.apache.org Message-ID: <715186481.52163.1306694628009.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1518161866.51299.1306623408453.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap the lockfactory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040848#comment-13040848 ] Shai Erera commented on LUCENE-3152: ------------------------------------ Robert, can we close this now that LUCENE-3147 is closed? > MockDirectoryWrapper should wrap the lockfactory > ------------------------------------------------ > > Key: LUCENE-3152 > URL: https://issues.apache.org/jira/browse/LUCENE-3152 > Project: Lucene - Java > Issue Type: Bug > Components: general/test > Reporter: Robert Muir > Fix For: 3.3, 4.0 > > Attachments: LUCENE-3152.patch > > > After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory. > I ran 'ant test' on linux 50 times, and it passed all 50 times. > But on windows, it failed often because of write.lock... this is because of unclosed writers in the test. > MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks. > Then hopefully these tests would fail on linux too. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org