Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Fri, 20 May 2011 18:56:47 +0000 (UTC)
From: "Gabriele Kahlout (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <655572835.31468.1305917807356.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <503902688.10835.1305311387357.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (SOLR-2513) Allow to subclass
 org.apache.solr.response.XMLWriter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036993#comment-13036993 ] 

Gabriele Kahlout edited comment on SOLR-2513 at 5/20/11 6:56 PM:
-----------------------------------------------------------------

why to 4.0 only? I think it can be applied to branch3-X too. Also hacking it in my local copy I'd make almost every field protected and remove the finals from the methods. Are you against that, or should I upload a suggested revision that does that?

      was (Author: simpatico):
    why to 4.0 only? I think it can be applied to trunk/branch3-X too. Also hacking it in my local copy I'd make almost every field protected and remove the finals from the methods. Are you against that, or should I upload a suggested revision that does that?
  
> Allow to subclass org.apache.solr.response.XMLWriter 
> -----------------------------------------------------
>
>                 Key: SOLR-2513
>                 URL: https://issues.apache.org/jira/browse/SOLR-2513
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>            Reporter: Gabriele Kahlout
>            Assignee: Ryan McKinley
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: SOLR-2513-XMLWriter.patch, SOLR-2513.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> Hacking/debugging/extending Solr with one's own ResponseWriter one might want to inherit functionality from XMLWriter. A trivial example is overriding writeDate(..) to use a different calendar/format.
> I asked about why it's made final on the mailing list[1].
> [1] http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3CBANLkTin4mXiyBZW3CK-K4Gwq4O6nnC2gWQ@mail.gmail.com%3E 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org