Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 25 May 2011 17:53:47 +0000 (UTC)
From: "Shai Erera (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <516739593.42859.1306346027694.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <648206168.42245.1306330247645.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (LUCENE-3144) FreqProxTermsWriter leaks file
 handles if exceptions are thrown during flush()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LUCENE-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-3144:
-------------------------------

    Component/s:     (was: general/test)
                 core/index
    Description: FreqProxTermsWriter leaks open file handles if exceptions are thrown during flush. Code needs to be protected by try-finally clauses.  (was: MockIndexOutputWrapper checks in various places dir.maybeThrowDeterminsticException(). If an exception is actually thrown, the IndexOutput is not closed, and therefore file handles remain open which prevent cleaning up directories on Windows (and LTC.afterClass prints nasty stack traces).

We should wrap every call with a try-catch -- if an exception is thrown, we should close() the underlying stream. This should be done to backwards too (in 3x).)
       Priority: Major  (was: Minor)
     Issue Type: Bug  (was: Test)
        Summary: FreqProxTermsWriter leaks file handles if exceptions are thrown during flush()  (was: MockIndexOutputWrapper should close() if dir.maybeThrowDeterminsticException() throws an exception)

Changed issue title and description.

> FreqProxTermsWriter leaks file handles if exceptions are thrown during flush()
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-3144
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3144
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3144.patch, LUCENE-3144.patch
>
>
> FreqProxTermsWriter leaks open file handles if exceptions are thrown during flush. Code needs to be protected by try-finally clauses.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org