Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 23 May 2011 18:20:47 +0000 (UTC)
From: "Gabriele Kahlout (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <248924653.36809.1306174847456.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1322639952.35529.1306140707866.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (SOLR-2537) Refactor Solr modules
 structure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038108#comment-13038108 ] 

Gabriele Kahlout edited comment on SOLR-2537 at 5/23/11 6:20 PM:
-----------------------------------------------------------------

Regarding the .zip it's indeed time-consuming to explore. I had summarized the the differences (essentially putting all children at the same level and changing the core pom.xml), and meant the zip just for extra reference.

BTW solution 1. could be implemented w/o changing dirs structure. Solr core becomes an aggregator, the tests/src becomes a child module, and there we have the 3 modules w/o circular dependency as described above. I think this is a more 'maven-friendly' solution to the maven-helper copy-paste workaround. What do you think?
I could try and patch that perhaps.

BTW, thank you for dedicating time to look into my issue.

      was (Author: simpatico):
    Regarding the .zip it's indeed time-consuming to explore. I had summarized the the differences (essentially putting all children at the same level and changing the core pom.xml), and meant the zip just for extra reference.

BTW solution 1. could be implemented w/o changing dirs structure. Solr core becomes an aggregator, the tests/src becomes a child module, and there we have the 3 modules w/o circular dependency as described above. I think this is a more 'maven-friendly' solution to the maven-helper copy-paste workaround. What do you think?
I could try and patch that perhaps.
  
> Refactor Solr modules structure
> -------------------------------
>
>                 Key: SOLR-2537
>                 URL: https://issues.apache.org/jira/browse/SOLR-2537
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module is in the src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and Testframework makes it impossible to add a depenency on Solr-3.2-SNAPHOST (Solr Search Server) since it's packaged as a war, to import EmbeddedSolrServer.java, for example. It has been discussed on the mailing list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which depend on Solr Core and on the Test Framework. The org burden of that extra module, versus the ease of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will build without passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the TestFramework module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the packages under Solr Core. 
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr TestFramework declare it with <classifier>tests</classifier>, which packages only the tests, and the Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1] http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3c2D127F11DC79714E9B6A43AC9458147FBAD42EAD@suex07-mbx-03.ad.syr.edu%3e
> [2] http://maven.apache.org/guides/mini/guide-attached-tests.html
> [3] I've successfully used it before. https://code.google.com/p/memorizeasy/source/browse/MemoPlatform/persistenceui/pom.xml

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org