Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 417934AEC for ; Sun, 29 May 2011 16:48:30 +0000 (UTC) Received: (qmail 42917 invoked by uid 500); 29 May 2011 16:48:28 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 42680 invoked by uid 500); 29 May 2011 16:48:28 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 42672 invoked by uid 99); 29 May 2011 16:48:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 May 2011 16:48:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 May 2011 16:48:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6F5C2E7A5D for ; Sun, 29 May 2011 16:47:47 +0000 (UTC) Date: Sun, 29 May 2011 16:47:47 +0000 (UTC) From: "Shai Erera (JIRA)" To: dev@lucene.apache.org Message-ID: <24651177.52045.1306687667452.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1014992356.45111.1306410347468.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3147) MockDirectoryWrapper should track open file handles of IndexOutput too MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040819#comment-13040819 ] Shai Erera commented on LUCENE-3147: ------------------------------------ ok I removed the call to checkpoint(), and do not track anyChanges anymore. I tried "svn diff --force", but still nothing. And yes, it's an "svn merge" that I did. I guess we don't post patches after backport very often, so not a biggy. I'll commit shortly. > MockDirectoryWrapper should track open file handles of IndexOutput too > ---------------------------------------------------------------------- > > Key: LUCENE-3147 > URL: https://issues.apache.org/jira/browse/LUCENE-3147 > Project: Lucene - Java > Issue Type: Test > Components: general/test > Reporter: Shai Erera > Assignee: Shai Erera > Priority: Minor > Fix For: 3.2, 4.0 > > Attachments: LUCENE-3147-3x.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch > > > MockDirectoryWrapper currently tracks open file handles of IndexInput only. Therefore IO files that are not closed do not fail our tests, which can then lead to test directories fail to delete on Windows. We should make sure all open files are tracked and if they are left open, fail the test. I'll attach a patch shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org