Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Fri, 6 May 2011 06:09:03 +0000 (UTC)
From: "Uwe Schindler (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <2074895249.27265.1304662143060.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2036311756.23072.1304547483115.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (SOLR-2497) Move Solr to new NumericField stored
 field impl of LUCENE-3065
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated SOLR-2497:
--------------------------------

    Attachment: SOLR-2497.patch

Huper duper patch that passes all tests!

In general the design of TrieField and its subclasses and the delegation in TrieDateField are somehow crazy. We should maybe remove the superclass TrieField completely and copy all code inside the imense switch statements to the subclasses/TrieDateField. I think the whole thing was done initially because the original committer (before 1.4) did not want to add lots of extra classes but shortly before release Yonik changed that to the current state.

There was also inconsistency between TrieDateField and TrieField (with type=DATE), thats now solved. My problem came from the refactoring I did to get rid of this. TrieField implemented toExternal() and indexedToReadable() incorrect, I only fixed toExternal() but missed indexedToReadable(); thanks @ Chris Male.

> Move Solr to new NumericField stored field impl of LUCENE-3065
> --------------------------------------------------------------
>
>                 Key: SOLR-2497
>                 URL: https://issues.apache.org/jira/browse/SOLR-2497
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2497.patch, SOLR-2497.patch, SOLR-2497.patch, SOLR-2497.patch
>
>
> This implements the changes to NumericField (LUCENE-3065) in Solr. TrieField & Co would use NumericField for indexing and reading stored fields. To enable this some missing changes in Solr's internals (Field -> Fieldable) need to be done. Also some backwards compatible stored fields parsing is needed to read pre-3.2 indexes without reindexing (as the format changed a little bit and Document.getFieldable returns NumericField instances now).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org