Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08F1965D8 for ; Fri, 20 May 2011 18:41:31 +0000 (UTC) Received: (qmail 92971 invoked by uid 500); 20 May 2011 18:41:30 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 92903 invoked by uid 500); 20 May 2011 18:41:30 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 92896 invoked by uid 99); 20 May 2011 18:41:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2011 18:41:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2011 18:41:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A9A8ED3148 for ; Fri, 20 May 2011 18:40:47 +0000 (UTC) Date: Fri, 20 May 2011 18:40:47 +0000 (UTC) From: "Gabriele Kahlout (JIRA)" To: dev@lucene.apache.org Message-ID: <1758081345.31433.1305916847691.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <503902688.10835.1305311387357.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (SOLR-2513) Allow to subclass org.apache.solr.response.XMLWriter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036993#comment-13036993 ] Gabriele Kahlout commented on SOLR-2513: ---------------------------------------- why to 4.0 only? I think it can be applied to trunk/branch3-X too. Also hacking it in my local copy I'd make almost every field protected and remove the finals from the methods. Are you against that, or should I upload a suggested revision that does that? > Allow to subclass org.apache.solr.response.XMLWriter > ----------------------------------------------------- > > Key: SOLR-2513 > URL: https://issues.apache.org/jira/browse/SOLR-2513 > Project: Solr > Issue Type: Improvement > Components: Response Writers > Reporter: Gabriele Kahlout > Assignee: Ryan McKinley > Priority: Trivial > Fix For: 4.0 > > Attachments: SOLR-2513-XMLWriter.patch, SOLR-2513.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > Hacking/debugging/extending Solr with one's own ResponseWriter one might want to inherit functionality from XMLWriter. A trivial example is overriding writeDate(..) to use a different calendar/format. > I asked about why it's made final on the mailing list[1]. > [1] http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3CBANLkTin4mXiyBZW3CK-K4Gwq4O6nnC2gWQ@mail.gmail.com%3E -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org