Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAF7A6C55 for ; Tue, 24 May 2011 21:27:30 +0000 (UTC) Received: (qmail 86456 invoked by uid 500); 24 May 2011 21:27:29 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 86396 invoked by uid 500); 24 May 2011 21:27:29 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 86389 invoked by uid 99); 24 May 2011 21:27:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2011 21:27:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2011 21:27:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A33B7DCF14 for ; Tue, 24 May 2011 21:26:48 +0000 (UTC) Date: Tue, 24 May 2011 21:26:48 +0000 (UTC) From: "Simon Willnauer (JIRA)" To: dev@lucene.apache.org Message-ID: <1510106259.40560.1306272408665.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <310660660.26677.1305814547481.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (SOLR-2530) Remove Noggit CharArr from FieldType MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated SOLR-2530: ---------------------------------- Attachment: SOLR-2530.patch updated patch to new suggest module and replaced the nocommit in SimpleFacets with a TODO. I will commit this soon if nobody objects. > Remove Noggit CharArr from FieldType > ------------------------------------ > > Key: SOLR-2530 > URL: https://issues.apache.org/jira/browse/SOLR-2530 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis > Affects Versions: 4.0 > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Priority: Minor > Labels: api-change > Fix For: 4.0 > > Attachments: SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch > > > FieldType#indexedToReadable(BytesRef, CharArr) uses a noggit dependency that also spreads into ByteUtils. The uses of this method area all convert to String which makes this extra reference and the dependency unnecessary. I refactored it to simply return string and removed ByteUtils entirely. The only leftover from BytesUtils is a constant, i moved that one to Lucenes UnicodeUtils. I will upload a patch in a second -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org