Return-Path: 
 <dev-return-70974-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CF66D4B47
	for <apmail-lucene-dev-archive@www.apache.org>;
 Mon, 23 May 2011 14:39:35 +0000 (UTC)
Received: (qmail 9289 invoked by uid 500); 23 May 2011 14:39:34 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 9222 invoked by uid 500); 23 May 2011 14:39:34 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 9215 invoked by uid 99); 23 May 2011 14:39:34 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2011 14:39:34 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2011 14:39:31 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 7C828D9A90
	for <dev@lucene.apache.org>; Mon, 23 May 2011 14:38:50 +0000 (UTC)
Date: Mon, 23 May 2011 14:38:50 +0000 (UTC)
From: "Steven Rowe (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <150646568.36082.1306161530505.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1322639952.35529.1306140707866.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2537) Refactor Solr modules structure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/SOLR-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037972#comment-13037972 ] 

Steven Rowe commented on SOLR-2537:
-----------------------------------

bq. Where is this issue going to?

I see two issues:

# AFAICT, you have a problem consuming Maven artifacts.
# You object to Solr's non-conventional project layout.

These are completely separate in my mind.  I think #2 is much, much harder to do than #1.  Let's work through #1.

I tried to reproduce your build problem, except I used the (default) HEAD revision of the branch_3x branch:

{quote}
svn co http://svn.apache.org/repos/asf/lucene/dev/branches/branch_3x/
cd branch_3x; ant get-maven-poms; mvn -N -Pbootstrap install; mvn -DskipTests install
wget http://dp4j.sf.net/debug/embeddedServerTest.zip
unzip embeddedServerTest.zip
cd embeddedServerTest; mvn -X test
{quote}

I looked over your POM and everything looks okay, with the exception that the solr test framework dependency should be declared as <scope>test</scope>.  I left it as-is, though, to see if it might be the source of problems.

The first problem I encountered is that Maven (v2.2.1) doesn't like annotations with the default Java 1.3 compiler setting.  So I added a maven-compiler-plugin configuration to your POM, with source and target set to 1.6.  This allowed everything to compile.

But you apparently don't have any real tests in your SolrConfigTest?  I don't see any @Test annotations, or methods named "test..." in SolrConfigTest.  This is the test output I get:

{quote}
-------------------------------------------------------------------------------
Test set: SolrConfigTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.062 sec <<< FAILURE!
initializationError(SolrConfigTest)  Time elapsed: 0.006 sec  <<< ERROR!
java.lang.RuntimeException: No runnable methods!
        at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.computeTestMethods(LuceneTestCase.java:1040)
{quote}

What happens for you?

> Refactor Solr modules structure
> -------------------------------
>
>                 Key: SOLR-2537
>                 URL: https://issues.apache.org/jira/browse/SOLR-2537
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module is in the src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and Testframework makes it impossible to add a depenency on Solr-3.2-SNAPHOST (Solr Search Server) since it's packaged as a war, to import EmbeddedSolrServer.java, for example. It has been discussed on the mailing list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which depend on Solr Core and on the Test Framework. The org burden of that extra module, versus the ease of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will build without passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the TestFramework module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the packages under Solr Core. 
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr TestFramework declare it with <classifier>tests</classifier>, which packages only the tests, and the Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1] http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3c2D127F11DC79714E9B6A43AC9458147FBAD42EAD@suex07-mbx-03.ad.syr.edu%3e
> [2] http://maven.apache.org/guides/mini/guide-attached-tests.html
> [3] I've successfully used it before. https://code.google.com/p/memorizeasy/source/browse/MemoPlatform/persistenceui/pom.xml

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org