Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 363A74647 for ; Fri, 13 May 2011 10:24:29 +0000 (UTC) Received: (qmail 72222 invoked by uid 500); 13 May 2011 10:24:27 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 72142 invoked by uid 500); 13 May 2011 10:24:27 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 72083 invoked by uid 99); 13 May 2011 10:24:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 10:24:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 10:24:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8D66C88A6D for ; Fri, 13 May 2011 10:23:47 +0000 (UTC) Date: Fri, 13 May 2011 10:23:47 +0000 (UTC) From: "Simon Willnauer (JIRA)" To: dev@lucene.apache.org Message-ID: <1171607949.9734.1305282227575.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <945164257.7265.1305219347392.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (LUCENE-3090) DWFlushControl does not take active DWPT out of the loop on fullFlush MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-3090: ------------------------------------ Attachment: LUCENE-3090.patch here is a patch. I fixed DWFlushControl to block flushes while a fullflush is happening and make them available once the fullflush is done. I also ensure that incoming threads help out flushing if there are DWPT about to flush but not taken yet before indexing their document. All tests pass (I run them lots of times :) > DWFlushControl does not take active DWPT out of the loop on fullFlush > --------------------------------------------------------------------- > > Key: LUCENE-3090 > URL: https://issues.apache.org/jira/browse/LUCENE-3090 > Project: Lucene - Java > Issue Type: Bug > Components: Index > Affects Versions: 4.0 > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Priority: Critical > Fix For: 4.0 > > Attachments: LUCENE-3090.patch > > > We have seen several OOM on TestNRTThreads and all of them are caused by DWFlushControl missing DWPT that are set as flushPending but can't full due to a full flush going on. Yet that means that those DWPT are filling up in the background while they should actually be checked out and blocked until the full flush finishes. Even further we currently stall on the maxNumThreadStates while we should stall on the num of active thread states. I will attach a patch tomorrow. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org